chore: Switch to EnvironmentSensorManager for re-usability#1571
Draft
thebino wants to merge 2 commits intomeshcore-dev:devfrom
Draft
chore: Switch to EnvironmentSensorManager for re-usability#1571thebino wants to merge 2 commits intomeshcore-dev:devfrom
thebino wants to merge 2 commits intomeshcore-dev:devfrom
Conversation
|
Why different hardware need to be in environment manager? Make environment manager platform independent and fine tune your platform in a way you need. Common code must be platform independent as much as possible. |
Author
|
Yes, thats what I did. Instead of 120 loc its now just 45 loc in the environment manager and no duplication anymore. |
|
Sorry if I overlooked, but... Who added T1000_GPS in EnvironmentSensors.cpp? Shouldn't it go to T1000 variant instead of Environment Sensors? |
Contributor
|
I haven't looked at the details but I agree with @JDat. The code in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of duplicating custom logic for every hardware, it would be nice to re-use existing code where possible.
The already existing EnvironmentSensorManager is used by many variants and does a good job.
This PR added the hardware specifics where needed.
Baseline for #1564